Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update claimed as tax dependent #541

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

jacobkagon
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements

  • The title follows our guidelines
  • Tests for the changes have been added (for bugfixes/features), they use let helpers and before blocks
  • For all UI changes, there is cucumber coverage
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, reasoning is documented in PR and code
  • For all scripts or rake tasks, how to run it is documented on both the PR and in the code
  • There are no inline styles added
  • There are no inline javascript added
  • There is no hard coded text added/updated in helpers/views/Javascript. New/updated translation strings do not include markup/styles, unless there is supporting documentation
  • Code does not use .html_safe
  • All images added/updated have alt text
  • Doesn’t bypass rubocop rules in any way

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix or migration (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)

What is the ticket # detailing the issue?

Ticket: https://www.pivotaltracker.com/n/projects/2640060/stories/188846893

A brief description of the changes

Current behavior: Primary applicants are being marked as claimed_as_tax_dependent by themselves

New behavior: Do not allow primary applicants to claim themselves as tax dependents.

Additional Context

Include any additional context that may be relevant to the peer review process.

@jacobkagon jacobkagon enabled auto-merge (squash) February 6, 2025 20:32
@jacobkagon jacobkagon disabled auto-merge February 6, 2025 22:06
@jacobkagon jacobkagon marked this pull request as draft February 6, 2025 22:06
@jacobkagon jacobkagon marked this pull request as ready for review February 6, 2025 22:18
@jacobkagon jacobkagon enabled auto-merge (squash) February 6, 2025 23:05
Copy link
Contributor

@vkghub vkghub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jayreddy519 jayreddy519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jacobkagon jacobkagon merged commit 15e5020 into trunk Feb 7, 2025
7 checks passed
@jacobkagon jacobkagon deleted the 188846893_update_claimed_as_tax_dependent branch February 7, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants