New error when two different ICs are specified #29672
Conversation
|
Job Documentation, step Docs: sync website on af85c85 wanted to post the following: View the site here This comment will be updated on new commits. |
|
So the other day I noticed there was one test that was failing with this new error message, and that was the restart/restart_diffusion.restart_error_with_ics test since my new error will get thrown before checkICRestartError does. The only case I could find where this doesn't happen is if you have two variables with one being restarted while the other is given an initial condition. If that is something we want to test for I can go ahead an modify that one test to have two variables instead. If not I have a few ideas for modifying my error check so that it doesn't interfere with the other one. |
|
you ll have to modify that test to hit the error, but through a different code path since you covered this one so yes the 2 variables idea is good! |
DanielYankura
force-pushed
the
multiple_IC_check
branch
from
4c39d28 to
f6e8dc0
Compare
|
let's squash formatting commits with the commit introducing the formatting problem or (and) even better, install the format hooks (see scripts/) to avoid failing the precheck |
DanielYankura
force-pushed
the
multiple_IC_check
branch
from
416be8b to
f61fac0
Compare
|
Job Coverage, step Generate coverage on af85c85 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
DanielYankura
force-pushed
the
multiple_IC_check
branch
from
f61fac0 to
1b4c5a7
Compare
test/tests/restart/restart_diffusion/gold/exodus_refined_restart_1.e
Outdated
Show resolved
Hide resolved
-Error thrown if an initial_condition parameter is provided along with an initial_from_file_var parameter for the same variable. closes idaholab#20944
-error message is worded more clearly now -initial_from_file_var is now a transfer param -test was updated to reflect new error message
…ndition + initial_from_file_var check
GiudGiud
force-pushed
the
multiple_IC_check
branch
from
1b4c5a7 to
af85c85
Compare
|
Failures are two unrelated timeouts. @DanielYankura if you're ok with the change I ll merge |
|
Sounds good. I took a look over the changes you made and I am good with them if you want to merge! |
-Error thrown if an initial_condition parameter is provided along with an initial_from_file_var parameter for the same variable.
closes #20944
Reason
This added error check will make debugging input files easier.
Design
Previously an error was only thrown if two initial_condition parameters were supplied for the same variable. Now an error is also thrown if an initial_from_file_var is also provided.
Impact