Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen hit.cpp w/ cython 3.0.11, remove conda/pyhit and fix find_moose_executable util #29624

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

nmnobre
Copy link
Member

@nmnobre nmnobre commented Dec 30, 2024

So we can build against Python 3.13.

@moosebuild
Copy link
Contributor

moosebuild commented Dec 30, 2024

Job Documentation, step Docs: sync website on 50b545d wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Dec 30, 2024

Job Coverage, step Generate coverage on 50b545d wanted to post the following:

Framework coverage

1e1768 #29624 50b545
Total Total +/- New
Rate 85.25% 85.25% -0.00% -
Hits 108011 108010 -1 0
Misses 18681 18682 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Member

@loganharbour loganharbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready for this until conda infrastructure changes are complete

@nmnobre this will also require a bump to conda packages, as the moose-pyhit conda package relies on this.

nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 2, 2025
@nmnobre
Copy link
Member Author

nmnobre commented Jan 2, 2025

Not ready for this until conda infrastructure changes are complete

@nmnobre this will also require a bump to conda packages, as the moose-pyhit conda package relies on this.

I'm a bit confused... I bumped the version in conda/pyhit/meta.yaml but as far as I can tell, that points to https://github.com/milljm/moose-pyhit.git anyway, which seems severely outdated? It both points to an old moose commit (which will of course not have the changes here to hit.cpp - and it's missing some previous changes too) but also doesn't seem to be up to date with python/pyhit/pyhit.py in this repo?

But, surely the apptainer/docker failures are unrelated to conda?

Cheers!

nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 3, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 3, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 3, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 3, 2025
@nmnobre
Copy link
Member Author

nmnobre commented Jan 4, 2025

@loganharbour All green. Thanks for the help and apologies for messing up #29589. Can I get this in before #29104? 😇

nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
@milljm
Copy link
Member

milljm commented Jan 7, 2025

Changing Python versions requires a change to the entire stack. You'll need to start at the beginning with moose-mpi:

- python >=3.9,<3.12

From experience, I can tell you I had issues getting our TestHarness to work with Python 3.12. So 3.13 may be quite the project!

Edit: My mistake, I thought we were attempting to bump Python, not make something else compatible with Python 3.13...

@nmnobre
Copy link
Member Author

nmnobre commented Jan 7, 2025

Edit: My mistake, I thought we were attempting to bump Python, not make something else compatible with Python 3.13...

Yes!
It's just I've got 3.13 on my machine and had to keep 3.12 around just because of MOOSE, in particular hit.cpp.
I tried regenerating with the latest Cython and it just worked, so that's all I need. :)

conda/pyhit/meta.yaml Outdated Show resolved Hide resolved
@nmnobre nmnobre changed the title Regenerate hit.cpp with cython 3.0.11 Regen hit.cpp w/ cython 3.0.11, remove conda/pyhit and fix find_moose_executable util Jan 7, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
Copy link
Member

@milljm milljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to address versioner.yaml file

scripts/tests/versioner_hashes.yaml Outdated Show resolved Hide resolved
conda/wasp/meta.yaml Outdated Show resolved Hide resolved
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
nmnobre added a commit to farscape-project/moose that referenced this pull request Jan 7, 2025
@moosebuild
Copy link
Contributor

Job Conda build (Intel Mac) on 50b545d : invalidated by @milljm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants