Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use k-loss coefficients in pressure drop calculation [!93 merged] #29389

Closed
moosebuild opened this issue Dec 10, 2024 · 24 comments
Closed

Use k-loss coefficients in pressure drop calculation [!93 merged] #29389

moosebuild opened this issue Dec 10, 2024 · 24 comments
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module imported merge request

Comments

@moosebuild
Copy link
Contributor

Imported from https://github.inl.gov/ncrc/subchannel/issues/166 : @moose-ncrc created issue at Jul 14, 2021 02:01PM MST:

In GitLab by @kyriv1980 on Jul 14, 2021, 15:01

Merges v_kyr1ak/axial_spacers -> devel

Merging this branch resolves issue #5

@moosebuild moosebuild added C: Modules/Subchannel Tickets pertaining to the subchannel module imported merge request labels Dec 10, 2024
@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 14, 2021 02:44PM MST:

In GitLab by @moosetest on Jul 14, 2021, 15:44

Job Test on d0561c6 wanted to post the following:

Code coverage: deleted

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 14, 2021 02:44PM MST:

In GitLab by @moosetest on Jul 14, 2021, 15:44

CIVET Testing summary for fd64b60

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 14, 2021 02:56PM MST:

In GitLab by @kyriv1980 on Jul 14, 2021, 15:56

added 1 commit

  • b6baac93 - Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 08:34AM MST:

In GitLab by @moosetest on Jul 15, 2021, 09:34

CIVET Testing summary for b6baac9

Precheck : Passed (Invalidated)
Test : Failed : test subchannel (Invalidated)
Test dbg : Passed (Invalidated)
Non unity build : Passed (Invalidated)
App tests : Passed (Invalidated)

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 11:34AM MST:

In GitLab by @andrsd on Jul 15, 2021, 12:34

added 1 commit

  • f7a77370 - fixup! Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 11:34AM MST:

In GitLab by @andrsd on Jul 15, 2021, 12:34

marked this merge request as draft from f7a77370de530747715d8c9f4b7a3d3126eb6a33

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 12:21PM MST:

In GitLab by @moosetest on Jul 15, 2021, 13:21

CIVET Testing summary for f7a7737

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 12:39PM MST:

In GitLab by @andrsd on Jul 15, 2021, 13:39

This should have been 2e-5

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 12:44PM MST:

In GitLab by @kyriv1980 on Jul 15, 2021, 13:44

changed this line in version 4 of the diff

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 12:44PM MST:

In GitLab by @kyriv1980 on Jul 15, 2021, 13:44

resolved all threads

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 12:44PM MST:

In GitLab by @kyriv1980 on Jul 15, 2021, 13:44

added 1 commit

  • d45bd7ba - fixup! Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 01:30PM MST:

In GitLab by @kyriv1980 on Jul 15, 2021, 14:30

added 1 commit

  • 1edd0c84 - fixup! Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 01:30PM MST:

In GitLab by @moosetest on Jul 15, 2021, 14:30

CIVET Testing summary for d45bd7b

Precheck : Passed
Test : Canceled by user
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 02:14PM MST:

In GitLab by @moosetest on Jul 15, 2021, 15:14

CIVET Testing summary for 1edd0c8

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 02:39PM MST:

In GitLab by @kyriv1980 on Jul 15, 2021, 15:39

added 1 commit

  • 317ba4f5 - fixup! Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 15, 2021 03:24PM MST:

In GitLab by @moosetest on Jul 15, 2021, 16:24

CIVET Testing summary for 317ba4f

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:50AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:50

marked this merge request as ready

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:50AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:50

marked this merge request as draft

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:51AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:51

marked this merge request as ready

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:54AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:54

added 1 commit

  • d0561c6b - Use k-loss coeffiecients in pressure drop calculation and regolded as needed Refs#5

Compare with previous version

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:54AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:54

approved this merge request

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 07:54AM MST:

In GitLab by @andrsd on Jul 16, 2021, 08:54

enabled an automatic merge when the pipeline for d0561c6b6d5a33f3572fa55c524394d3a99ce6d9 succeeds

@moosebuild
Copy link
Contributor Author

@moose-ncrc commented at Jul 16, 2021 08:38AM MST:

In GitLab by @moosetest on Jul 16, 2021, 09:38

CIVET Testing summary for d0561c6

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Passed

@moosebuild
Copy link
Contributor Author

Issue closed at: Jan 16, 2023 07:07PM MST by @moose-ncrc

kyriv1980 pushed a commit to loganharbour/moose that referenced this issue Jan 6, 2025
loganharbour pushed a commit to loganharbour/moose that referenced this issue Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules/Subchannel Tickets pertaining to the subchannel module imported merge request
Projects
None yet
Development

No branches or pull requests

1 participant