Add munkm feedback to JOSS paper #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: manually close #433 as this isn't merging into develop. |
tjlaboss
requested changes
Feb 3, 2025
Comment on lines
+115
to
+314
|
|
||
| @software{shimwell_neutronics_2024, | ||
| title = {Neutronics Material Maker}, | ||
| url = {https://github.com/fusion-energy/neutronics_material_maker}, | ||
| version = {1.2.1}, | ||
| author = {Shimwell, Jonathan and Billingsley, John and Buendia, Coronel and {Neutronics Material Material Contributors}}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{repositony_vscode_mcnp_2024, | ||
| title = {vscode\_mcnp}, | ||
| url = {https://github.com/repositony/vscode_mcnp}, | ||
| author = {{Repositony}}, | ||
| date = {2024}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{turkoglu_mcnp-syntax-highlighting_2018, | ||
| title = {{MCNP}-syntax-highlighting}, | ||
| url = {https://github.com/danyalturkoglu/MCNP-syntax-highlighting}, | ||
| author = {Turkoglu, Danyal}, | ||
| date = {2018}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{mancusi_t4_geom_convert_2024, | ||
| title = {t4\_geom\_convert}, | ||
| url = {https://github.com/arekfu/t4_geom_convert}, | ||
| version = {1.1.2}, | ||
| author = {Mancusi, Davide}, | ||
| date = {2024}, | ||
| keywords = {conversions, converter, read input}, | ||
| } | ||
|
|
||
| @software{pease_pymcnp_2025, | ||
| title = {{PyMCNP}}, | ||
| url = {https://github.com/FSIBT/PyMCNP}, | ||
| author = {Pease, Devin and Ayllon Unzueta, Mauricio and Surry, Emily and Persaud, Arun}, | ||
| date = {2025}, | ||
| keywords = {input {API}}, | ||
| } | ||
|
|
||
| @software{portnov_map-stp_2024, | ||
| title = {map-stp}, | ||
| url = {https://github.com/MC-kit/map-stp}, | ||
| author = {Portnov, Dimitri}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{hung_mcnp6-hpge_detector_simulation_2023, | ||
| title = {{MCNP}6-{HPGE}\_Detector\_Simulation}, | ||
| url = {https://github.com/hungbt1908/MCNP6-HPGE_Detector_Simulation}, | ||
| author = {Hung, Bui Tien}, | ||
| date = {2023}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{galdon_bemp_thesis_2024, | ||
| title = {{BEMP}\_Thesis}, | ||
| url = {https://github.com/mgaldon17/BEMP_Thesis}, | ||
| version = {1.0.0}, | ||
| author = {Galdon, Manuel}, | ||
| date = {2024}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{niess_gdnp_2018, | ||
| title = {{GDNP}}, | ||
| url = {https://github.com/niess/gdnp}, | ||
| author = {{niess}}, | ||
| date = {2018}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{richet_funz_2023, | ||
| title = {Funz Plugin-{MCNP}}, | ||
| url = {https://github.com/Funz/plugin-MCNP}, | ||
| version = {1.16-0}, | ||
| author = {Richet, Yann}, | ||
| date = {2023}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{ikarino_mcnp_2021, | ||
| title = {{MCNP} Input Generator}, | ||
| url = {https://github.com/ikarino/mcnp_input_generator}, | ||
| author = {{ikarino}}, | ||
| date = {2021}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{park_rodcal-mcnp_2021, | ||
| title = {rodcal-mcnp}, | ||
| url = {https://github.com/patrickpark910/rodcal-mcnp}, | ||
| author = {Park, Patrick}, | ||
| date = {2021}, | ||
| keywords = {specific problem automation}, | ||
| } |
There was a problem hiding this comment.
References are triplicated.
Comment on lines
+315
to
+513
|
|
||
| @software{shimwell_neutronics_2024, | ||
| title = {Neutronics Material Maker}, | ||
| url = {https://github.com/fusion-energy/neutronics_material_maker}, | ||
| version = {1.2.1}, | ||
| author = {Shimwell, Jonathan and Billingsley, John and Buendia, Coronel and {Neutronics Material Material Contributors}}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{repositony_vscode_mcnp_2024, | ||
| title = {vscode\_mcnp}, | ||
| url = {https://github.com/repositony/vscode_mcnp}, | ||
| author = {{Repositony}}, | ||
| date = {2024}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{turkoglu_mcnp-syntax-highlighting_2018, | ||
| title = {{MCNP}-syntax-highlighting}, | ||
| url = {https://github.com/danyalturkoglu/MCNP-syntax-highlighting}, | ||
| author = {Turkoglu, Danyal}, | ||
| date = {2018}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{mancusi_t4_geom_convert_2024, | ||
| title = {t4\_geom\_convert}, | ||
| url = {https://github.com/arekfu/t4_geom_convert}, | ||
| version = {1.1.2}, | ||
| author = {Mancusi, Davide}, | ||
| date = {2024}, | ||
| keywords = {conversions, converter, read input}, | ||
| } | ||
|
|
||
| @software{pease_pymcnp_2025, | ||
| title = {{PyMCNP}}, | ||
| url = {https://github.com/FSIBT/PyMCNP}, | ||
| author = {Pease, Devin and Ayllon Unzueta, Mauricio and Surry, Emily and Persaud, Arun}, | ||
| date = {2025}, | ||
| keywords = {input {API}}, | ||
| } | ||
|
|
||
| @software{portnov_map-stp_2024, | ||
| title = {map-stp}, | ||
| url = {https://github.com/MC-kit/map-stp}, | ||
| author = {Portnov, Dimitri}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{hung_mcnp6-hpge_detector_simulation_2023, | ||
| title = {{MCNP}6-{HPGE}\_Detector\_Simulation}, | ||
| url = {https://github.com/hungbt1908/MCNP6-HPGE_Detector_Simulation}, | ||
| author = {Hung, Bui Tien}, | ||
| date = {2023}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{galdon_bemp_thesis_2024, | ||
| title = {{BEMP}\_Thesis}, | ||
| url = {https://github.com/mgaldon17/BEMP_Thesis}, | ||
| version = {1.0.0}, | ||
| author = {Galdon, Manuel}, | ||
| date = {2024}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{niess_gdnp_2018, | ||
| title = {{GDNP}}, | ||
| url = {https://github.com/niess/gdnp}, | ||
| author = {{niess}}, | ||
| date = {2018}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{richet_funz_2023, | ||
| title = {Funz Plugin-{MCNP}}, | ||
| url = {https://github.com/Funz/plugin-MCNP}, | ||
| version = {1.16-0}, | ||
| author = {Richet, Yann}, | ||
| date = {2023}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{ikarino_mcnp_2021, | ||
| title = {{MCNP} Input Generator}, | ||
| url = {https://github.com/ikarino/mcnp_input_generator}, | ||
| author = {{ikarino}}, | ||
| date = {2021}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{park_rodcal-mcnp_2021, | ||
| title = {rodcal-mcnp}, | ||
| url = {https://github.com/patrickpark910/rodcal-mcnp}, | ||
| author = {Park, Patrick}, | ||
| date = {2021}, | ||
| keywords = {specific problem automation}, | ||
| } |
Comment on lines
+514
to
+712
|
|
||
| @software{shimwell_neutronics_2024, | ||
| title = {Neutronics Material Maker}, | ||
| url = {https://github.com/fusion-energy/neutronics_material_maker}, | ||
| version = {1.2.1}, | ||
| author = {Shimwell, Jonathan and Billingsley, John and Buendia, Coronel and {Neutronics Material Material Contributors}}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{repositony_vscode_mcnp_2024, | ||
| title = {vscode\_mcnp}, | ||
| url = {https://github.com/repositony/vscode_mcnp}, | ||
| author = {{Repositony}}, | ||
| date = {2024}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{turkoglu_mcnp-syntax-highlighting_2018, | ||
| title = {{MCNP}-syntax-highlighting}, | ||
| url = {https://github.com/danyalturkoglu/MCNP-syntax-highlighting}, | ||
| author = {Turkoglu, Danyal}, | ||
| date = {2018}, | ||
| keywords = {syntax highlighter}, | ||
| } | ||
|
|
||
| @software{mancusi_t4_geom_convert_2024, | ||
| title = {t4\_geom\_convert}, | ||
| url = {https://github.com/arekfu/t4_geom_convert}, | ||
| version = {1.1.2}, | ||
| author = {Mancusi, Davide}, | ||
| date = {2024}, | ||
| keywords = {conversions, converter, read input}, | ||
| } | ||
|
|
||
| @software{pease_pymcnp_2025, | ||
| title = {{PyMCNP}}, | ||
| url = {https://github.com/FSIBT/PyMCNP}, | ||
| author = {Pease, Devin and Ayllon Unzueta, Mauricio and Surry, Emily and Persaud, Arun}, | ||
| date = {2025}, | ||
| keywords = {input {API}}, | ||
| } | ||
|
|
||
| @software{portnov_map-stp_2024, | ||
| title = {map-stp}, | ||
| url = {https://github.com/MC-kit/map-stp}, | ||
| author = {Portnov, Dimitri}, | ||
| date = {2024}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{hung_mcnp6-hpge_detector_simulation_2023, | ||
| title = {{MCNP}6-{HPGE}\_Detector\_Simulation}, | ||
| url = {https://github.com/hungbt1908/MCNP6-HPGE_Detector_Simulation}, | ||
| author = {Hung, Bui Tien}, | ||
| date = {2023}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{galdon_bemp_thesis_2024, | ||
| title = {{BEMP}\_Thesis}, | ||
| url = {https://github.com/mgaldon17/BEMP_Thesis}, | ||
| version = {1.0.0}, | ||
| author = {Galdon, Manuel}, | ||
| date = {2024}, | ||
| keywords = {specific problem automation}, | ||
| } | ||
|
|
||
| @software{niess_gdnp_2018, | ||
| title = {{GDNP}}, | ||
| url = {https://github.com/niess/gdnp}, | ||
| author = {{niess}}, | ||
| date = {2018}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{richet_funz_2023, | ||
| title = {Funz Plugin-{MCNP}}, | ||
| url = {https://github.com/Funz/plugin-MCNP}, | ||
| version = {1.16-0}, | ||
| author = {Richet, Yann}, | ||
| date = {2023}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{ikarino_mcnp_2021, | ||
| title = {{MCNP} Input Generator}, | ||
| url = {https://github.com/ikarino/mcnp_input_generator}, | ||
| author = {{ikarino}}, | ||
| date = {2021}, | ||
| keywords = {input templater}, | ||
| } | ||
|
|
||
| @software{park_rodcal-mcnp_2021, | ||
| title = {rodcal-mcnp}, | ||
| url = {https://github.com/patrickpark910/rodcal-mcnp}, | ||
| author = {Park, Patrick}, | ||
| date = {2021}, | ||
| keywords = {specific problem automation}, | ||
| } |
Comment on lines
+127
to
+132
| PyNE can create MCNP input files for specific features, and extract some data from MCNP output files, | ||
| however its true capabilities extend far beyond interfacing with MCNP. | ||
| It can: simplify material creation, analyzing cross section data, | ||
| complete transmutations for complex systems, | ||
| interface with other common nuclear engineering software, | ||
| and common nuclear data formats [@Scopatz:2012]. |
There was a problem hiding this comment.
I suggest:
PyNE can create MCNP input files for specific features and extract some data from MCNP output files.
However, its full capabilities extend far beyond interfacing with MCNP.
PyNE can simplify material creations, analyses of cross section data, transmutations of complex systems, and interfacing with other common nuclear engineering software and data formats.
There was a problem hiding this comment.
In formal writing, colons shouldn't separate a phrase. Something like, "It can do several things:" is permissible.
The rest fixes parallelism. I shouldn't really mix a gerund ("interfacing") with the other nouns, but stating that it simplifies "interfaces" might change the implication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This is for the feedback in #646 that is related to the joss paper as those shouldn't be merged into develop.
Fixes #646, Fixes #433.
General Checklist
Documentation Checklist
First-Time Contributor Checklist
pyproject.tomlif you wish to do so.Additional Notes for Reviewers
Ensure that:
📚 Documentation preview 📚: https://montepy--649.org.readthedocs.build/en/649/