Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for basic_auth headers #74

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Fix for basic_auth headers #74

merged 3 commits into from
Jun 19, 2019

Conversation

kalinon
Copy link
Contributor

@kalinon kalinon commented Jun 18, 2019

Fix for #73

@icyleaf icyleaf added the bug label Jun 19, 2019
@icyleaf
Copy link
Owner

icyleaf commented Jun 19, 2019

@kalinon Thanks for PR, i added some tests but the CI was not triggering build. i will fix it then to merge.

icyleaf
icyleaf approved these changes Jun 19, 2019
View reviewed changes
Copy link
Owner

@icyleaf icyleaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed with Crystal 0.29 is because to update generated docs, it could be ignore in PR.

@icyleaf icyleaf merged commit 414cfd0 into icyleaf:master Jun 19, 2019
@kalinon
Copy link
Contributor Author

kalinon commented Jun 19, 2019

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icyleaf icyleaf icyleaf approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalinon @icyleaf