Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] dSYM parser add multi dsym support #56

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

icyleaf
Copy link
Owner

@icyleaf icyleaf commented Mar 30, 2023

This is a feature and also a breaking changes.

AppInfo::DSYM class move mostly of methods to a new class named AppInfo::DSYM::DebugInfo, and use .files method iterater the value.

Example

Get dSYM object, release_version etc

Before

p = AppInfo.parse('dsym.zip')
p.object             # => 'AppInfo'
p.release_version    # => '1.0'

After

p = AppInfo.parse('dsym.zip')

# Get all dSYM debug info file
p.files                # => [<AppInfo::DSYM::DebugInfo>, <AppInfo::DSYM::DebugInfo>]

# Or use iterater
p.each_file do |file|
  p.object             # => 'AppInfo'
  p.release_version    # => '1.0'
end        

More examples to review spec/app_info/dsym_spec.rb file.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 30, 2023
@icyleaf icyleaf force-pushed the feature/multi-dsym-support branch from a94daad to 657a99a Compare March 30, 2023 11:27
@icyleaf icyleaf merged commit aac848d into main Mar 31, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Mar 31, 2023
@icyleaf icyleaf deleted the feature/multi-dsym-support branch March 31, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant