Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torso_joints number in all-mc_remapper.xml after removing torso_pitch #116

Merged
merged 1 commit into from
May 18, 2023

Conversation

martinaxgloria
Copy link
Member

I added the all-mc_remapper.xml and all-mc_remapper_ros2.xml under ../urdf/simmechanics since they existed only under ../urdf/ergoCub and I updated the number of torso_joints from 3 to 2 after removing torso_pitch from conf files.

@martinaxgloria martinaxgloria requested a review from Nicogene May 18, 2023 09:57
@martinaxgloria martinaxgloria self-assigned this May 18, 2023
@martinaxgloria martinaxgloria changed the title Update torso_joints number all-mc_remapper.xml after removing torso_pitch Update torso_joints number in all-mc_remapper.xml after removing torso_pitch May 18, 2023
@Nicogene Nicogene merged commit 3f0561f into icub-tech-iit:master May 18, 2023
@Nicogene
Copy link
Member

Merged, thanks!

@traversaro
Copy link
Member

Note that for keeping things aligned with the real robot, we could think about using axesNames parameter in place of the networks one, see for example https://github.com/robotology/robots-configuration/blob/devel/ergoCubSN000/wrappers/motorControl/alljoints-mc_remapper.xml (changed in https://github.com/robotology/robots-configuration/pull/502/files ).

@martinaxgloria martinaxgloria deleted the feat/ros2 branch May 29, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants