-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tar): support for async streams #746
Conversation
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
+ Coverage 73.83% 74.11% +0.27%
==========================================
Files 69 71 +2
Lines 8355 8441 +86
==========================================
+ Hits 6169 6256 +87
+ Misses 2186 2185 -1
Continue to review full report at Codecov.
|
Wow, for some reason I thought Anyway, this mostly looks great, but it does lower the test coverage a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be some more tests with the async versions of the code, but otherwise it looks good. Great work!
Thanks for the feedback! I will create some more tests to cover the changes |
Some extra tests have now been added. |
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.
Relates to #223
I have taken a first pass at making TAR support async streams which will help with streaming to and from network streams. I have also tried to dramatically reduce memory allocations associated with reading from and writing to TAR's.
I haven't added new tests yet or really checked what the coverage is like but if you are happy with how it looks as it, I can do that.
Below are some benchmarks run before and after my changes:
Before:
After: