chore: remove the test bootstrapper #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 73.07% 73.31% +0.24%
==========================================
Files 68 68
Lines 8305 8305
==========================================
+ Hits 6069 6089 +20
+ Misses 2236 2216 -20
Continue to review full report at Codecov.
|
|
'interesting' how #630 talks about unstable coverage, and this is showing a coverage change in the deflater code that should be unaffected by the change :-( |
|
Yeah, there are still randomness in the test cases which causes some areas to only be covered with the "correct" seed. |
|
I have gone through all tests using |
piksel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #630
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.