Update and minimize sample project package dependencies #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
changed the title
Numpsy
force-pushed
the
rw/samples/reduce_references
branch
from
6a6f775 to
25fa365
Compare
piksel
approved these changes
May 27, 2020
Numpsy
force-pushed
the
rw/samples/reduce_references
branch
from
25fa365 to
a60c75d
Compare
|
Updated to change all the C# sample projects, and to change a couple of uses of |
Numpsy
changed the title
Numpsy
force-pushed
the
rw/samples/reduce_references
branch
from
a60c75d to
a6624ba
Compare
piksel
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing around the project insights github page and noticed that the package dependencies listed on the dependancy graph page looked rather seriously excessive, so I thought a spring clean might be in order.
(Looking at the history, it looks like the extra deps come are as a result of pointing the .net 4.6.1 sample projects at a build of the lib that only targeted .NET Standard 1.3, so shouldn't matter not the lib targets .NET 4.5 again)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.