Add a leaveOpen parameter to the ZipFile constructor, used to set the… #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default value of isStreamOwner
|
Good choices! Some simple unit tests for new constructors should probably be added. |
Numpsy
changed the title
|
added a few tests |
|
Great quality PR! Thank you. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… default value of isStreamOwner
Related to #144 - This change adds an extra version of the constructor for ZipFile which takes a 'leaveOpen' flag, which can be set to set the isStreamOwner flag during construction rather than after, which can help avoid unwanted stream disposal if the constructor throws (the param is called leaveOpen rather than isStreamOwner to match the naming of various other .net libs, and could be changed).
[WIP] because it could do with some tests if deemed a reasonable thing to do.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.