FastZip: Raise ProcessDirectory event for extractions #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
requested changes
Jul 1, 2018
FastZip's ExtractZip method did not raise the ProcessDirectory event when creating a directory. There was no way to determine or control when ExtractZip decided to create a new directory. NOTE: The logic to raise the event only triggers when the target directory doesn't already exist in the destination.
piksel
approved these changes
Aug 15, 2020
|
I commited my suggestion and rebased on master, this could be useful for determining if directories were created upon extraction (as per the original description). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastZip's ExtractZip method did not raise the ProcessDirectory event when
creating a directory. There was no way to determine or control when
ExtractZip decided to create a new directory.
(This presented an issue when I tried using ExtractZip in conjunction as part of an installation tool with automatic-rollback functionality; it did not rollback the creation of directories, so the cleanup didn't work correctly.)
NOTE: The logic to raise the event only triggers when the target directory
doesn't already exist in the destination.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.