-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate unique names for nodes in 3d models #795
generate unique names for nodes in 3d models #795
Conversation
[CI BUILD DEV]
Please make sure you're either using pre-commit locally or something else (Rider?) that handles the formatting as defined in .editorconfig |
This commit improves developer experience as the original node name is kept visible, and the UID is appended to the end [CI BUILD DEV] [CI BUILD]
This PR is ready for review @andybak TLDR:
Profiling: I didn't want there to be an insane frame freeze when the user imports a 3d model and the node tree is traversed and unique names are generated. Some notes:
For a model with 1000 empty nodes, it takes ~3ms to traverse the tree and generate unique names: This video shows importing models with 100, 1k, 10k, and 100k nodes. The model has completed loading and the unique names have been generated when the preview appears (which for these models is empty as there's no geometry data). Note that the node tree traversal is only a part of the import.
0376-0889.mp4 |
c228c1a
into
icosa-foundation:feature/icosa-integration
This PR introduces a dictionary in
Model.cs
for having a unique id for each node in a 3d model. It fixes string handling related issues in ModelWidget, #794Todo:
Transform.Find()
for node search, a custom method is implemented.