Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable masking of UNITY_PASSWORD #566

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Nov 23, 2023

This is NOT a security feature! The value stored in the file in the clear is still stored there! This merely hides the print in the builder action, making it slightly less obvious. (this only applies to runs from forks; from the repo, it's always masked because it comes from a secret)

@mikeage mikeage self-assigned this Nov 23, 2023
@mikeage mikeage added the infrastructure Build or tooling infrastructure label Nov 23, 2023
@mikeage mikeage merged commit a21ffc5 into icosa-foundation:main Nov 23, 2023
11 of 12 checks passed
@mikeage mikeage deleted the mask_pw branch November 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant