Camera path workflow improvements #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fail currently due to app signing issues.
…e used by the pull" This reverts commit 2bad0aa.
…h-workflow-improvements
…h-workflow-improvements
|
I just synced with the tip of main to make sure it looks good on the new unity (also I wanted to compare build times and this became my guinea pig) |
mikeage
approved these changes
Oct 27, 2023
andybak
added a commit
that referenced
this pull request
Oct 27, 2023
Now #544 is merged this makes sense.
andybak
added a commit
that referenced
this pull request
Nov 20, 2023
* Allow distinct Quest vs Experimental panel config * Add camera path button to Quest/Standalone Extra Tools panel Now #544 is merged this makes sense. * Repaint Selected was missing from mobile selection tray * Use experimental brush panel instead of mobile panel for Quest/Standalone
andybak
added a commit
that referenced
this pull request
Nov 25, 2023
Merged
mikeage
pushed a commit
that referenced
this pull request
Nov 25, 2023
* Scripts button was off center * Camera paths panel should be valid on quest now See #544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR warns Quest/standalone users that they can't record camera paths directly. The included script makes it possible to record without a headset and the MacOS changes enable feature parity (Linux users could potentially also be supported at a future date - probably by using a system-installed ffmpeg)
Note that you can't skip the "in app" recording as this is where the usd file for offline rendering is created. We can't create this directly on the Quest because the USD libraries don't run on Android. (I could generate the USD manually using the existing one as a template but I'll leave that for another PR)
The camera path panel currently only appears in experimental mode on the Quest. We could potentially move it to non-experimental mode if this PR proves itself in actual usage.