Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better normal map exports #534

Closed
wants to merge 36 commits into from
Closed

Better normal map exports #534

wants to merge 36 commits into from

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Sep 18, 2023

We currently export grayscale height maps instead of proper normal maps and fix this in the shader. I don't know the reason for this but for any export targets that don't use our shaders (Blender, Godot, Unreal etc etc) this means even brushes that can use fairly standard PBR shaders look pretty bad.

[CI BUILD]
@andybak
Copy link
Contributor Author

andybak commented Sep 18, 2023

This is a pretty old PR. I've been keeping it in sync with main but looking back, I have a couple of concerns:

  1. I can't recall how I did the conversion but the Unity Editor has an API that matches what happens automatically on import so we should use that (assuming I didn't originally)
  2. The changes to the materials look a bit concerning. I probably accepted whatever Unity did automatically but I'd like to redo it and see if we get the same diff.

@andybak
Copy link
Contributor Author

andybak commented Sep 18, 2023

Also see #308 for some other issues that probably need considering.

@mikeskydev mikeskydev added the enhancement Feature added label Sep 18, 2023
@mikeskydev
Copy link
Member

Some of those imports seem to have dramatically changed some import settings in the .meta files for the textures too, should probably give everything a proper check?

@andybak
Copy link
Contributor Author

andybak commented Sep 18, 2023

Yeah - that's pretty much what I mean with my point 2 above. I'm going to redo this PR so I should probably make it draft in the meantime.

@andybak andybak marked this pull request as draft September 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants