Change SketchFab uploads to upload as Open Brush #51
Conversation
PerlinWarp
changed the title
|
I can see both tags, but not the source. Do Sketchfab need to approve the source name from their side? I also tried changing the source name to |
|
@PerlinWarp based on our conversation we're just waiting on Sketchfab here, is this good to commit anyways? |
|
@mikeskydev I am yet to test this actually works, after writing it I needed secrets then got sidetracked by the Quest crashing bug. Sketchfab says it should work using a custom source but I wanted an example Sketchfab upload to post before merging. Apologies for the delay! |
|
We don't do secrets in PR builds from forks (because they rely on secrets and forks are not guaranteed to be safe from credential leakage), but after #71 is merged, if you want to open a PR from a branch of this repo rather than a fork (and I believe you have write permissions), you can get the sketchfab secrets built in to your CI build! |
PerlinWarp
force-pushed
the
SketchFabUploadPOST
branch
from
f9dc72c to
1d3fc5a
Compare
|
Rebased and retested. PCVR Upload Test I can now send these to SketchFab to use as examples of what uploads from Open Brush will look like and what the source tag will be. So after merging this PR, the source tag will be "open-brush" and new uploads will be given tags: "openbrush" and "tiltbrush". Before I sent these to SketchFab, can I confirm we want to use these tags? |
It looks like you're sending
source: "tilt-brush"and tagstags: ["tiltbrush"]in the upload POST. If you change those toopen-brushoropenbrush, I'll take care of the rest on my end. Just let me know which you choose for each. - James Green, SketchFabLet me do some more testing before merging.