Mac fixes #458
Closed
Mac fixes #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andybak
commented
Jun 18, 2023
andybak
commented
- Replace CSCore with a pure C# UPM package
- Add a #if !SHADER_API_METAL to bloom post-processing shader
mikeage
requested changes
Jun 18, 2023
|
|
||
| // OpenXR | ||
| new KeyValuePair<XrSdkMode, BuildTarget>(XrSdkMode.OpenXR, BuildTarget.StandaloneWindows64), | ||
| new KeyValuePair<XrSdkMode, BuildTarget>(XrSdkMode.OpenXR, BuildTarget.StandaloneOSX), |
There was a problem hiding this comment.
If this is a valid combination, can you add it to the CI please?
There was a problem hiding this comment.
I will do once it's working. Still very much WIP
There was a problem hiding this comment.
Ah. I see what I've done. I made the PR and then continued working on stuff, forgetting about the PR. I should create a new branch to separate out PR-ready from WIP. My mistake.
# Conflicts: # Packages/manifest.json # Packages/packages-lock.json
…nd was missing in previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.