Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate export folder and config for Open Brush #13

Merged
merged 2 commits into from
Jan 30, 2021

Conversation

PerlinWarp
Copy link
Member

@PerlinWarp PerlinWarp commented Jan 30, 2021

First Commit
Store exports in Documents/OpenBrush not TiltBrush, and use separate Open Brush config file.

Note to devs:
I hope you did not clone the repo as C:\Users{USER}\Documents\Open Brush
or your might get Sketches in your repo.

Second Commit
Changed the version number to 0.1.0 as requested by @mikeskydev

@PerlinWarp
Copy link
Member Author

There's a few changes to ProjectSettings that I have not added to the commit, I believe its due to me switching back from Oculus to PC build. Not sure if changing the version number in Config would have changed anything but the Main scene, so this needs checking.

@@ -3242,7 +3280,7 @@ MonoBehaviour:
m_OdsOutputPrefix:
m_ControlsPrefabOverrideOvr: {fileID: 0}
m_ControlsPrefabOverrideSteamVr: {fileID: 0}
m_VersionNumber: 24.0b
m_VersionNumber: 0.1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bam, hopefully that's all that needs to be committed.

@PerlinWarp PerlinWarp added bug Something isn't working bugfix Something has been fixed and removed bug Something isn't working labels Jan 30, 2021
Copy link
Member

@mikeskydev mikeskydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Folder and config generated correctly.

@PerlinWarp PerlinWarp merged commit 3a5eed1 into icosa-foundation:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants