Implement failsafe logic for GenerateUniqueRoomName

We limit the attempts to 10
icosa-foundation · Dec 11, 2024 · 5d623a2 · 5d623a2
1 parent 65d3a8a
commit 5d623a2
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/Assets/Scripts/GUI/MultiplayerPanel.cs b/Assets/Scripts/GUI/MultiplayerPanel.cs
@@ -113,11 +113,22 @@ protected override void OnDisablePanel()
 
         private static string GenerateUniqueRoomName()
         {
+            const int maxAttempts = 10;
             string roomName;
+            int attempts = 0;
+
             do
             {
                 roomName = GenerateRandomRoomName();
-            } while (MultiplayerManager.m_Instance != null && MultiplayerManager.m_Instance.DoesRoomNameExist(roomName));
+                attempts++;
+            } while (MultiplayerManager.m_Instance != null &&
+             MultiplayerManager.m_Instance.DoesRoomNameExist(roomName) &&
+             attempts < maxAttempts);
+
+            if (attempts >= maxAttempts)
+            {
+                return "default room";
+            }
 
             return roomName;
         }