Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading attachments from test run completed event #8

Merged
merged 4 commits into from
Jan 20, 2022
Merged

Uploading attachments from test run completed event #8

merged 4 commits into from
Jan 20, 2022

Conversation

icnocop
Copy link
Owner

@icnocop icnocop commented Mar 6, 2021

No description provided.

@icnocop icnocop changed the title [WIP] Uploading attachments from test run completed event Uploading attachments from test run completed event Mar 7, 2021
@icnocop icnocop requested a review from daveaglick March 7, 2021 06:12
Not reporting duration for test run because it's automatically calculated by Azure DevOps.
@daveaglick
Copy link
Collaborator

Very nice! Sorry this sat around for [checks date] almost a year 😱. I love both the use of an enum for outcome and the attachment capability.

BTW - always feel free to ping me or go ahead and merge stuff yourself since you have collaborator rights, and then ping me so I can release it :). I'm spread pretty thin open source wise these days and often forget about pending PRs in some of my lesser-touched projects.

@daveaglick daveaglick merged commit b4f7db8 into icnocop:main Jan 20, 2022
@daveaglick
Copy link
Collaborator

@icnocop Published a new release to NuGet. BTW - since I'm not even using this anymore, do you have any interest in completely taking over the project (I.e. transferring it to your GitHub account and adding as an owner to the NuGet package)? I'm happy to continue merging your PRs and releasing, but it probably makes sense to cut out the middle-man at this point.

@icnocop
Copy link
Owner Author

icnocop commented Jan 20, 2022

Thank you for reviewing and merging the code, and also for publishing a new release. 🎉

Yes, you can transfer the Github project and NuGet package ownership to me.

I understand the need to prioritize your time. 👍🏻

My NuGet.org profile user name is rami.abughazaleh.

Thank you!

@daveaglick
Copy link
Collaborator

It's all yours :)

I transferred the repo (pending approval) and added you as a package owner (feed free to remove me once you're up and running if you want). Thanks again for running with this project - it was a fun one and fills an unfortunate gap in Azure Pipelines. Let me know if I can do anything to help going forward - I think you might need to adjust the build and release scripts a bit, but hopefully that's self-explanatory. Or just start over in that regard, your choice :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants