Include code to workaround auth problems #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added function that return calendars - names, guid, url and more
… set the time to the earliest valid time (in 1970)
…uests in pyvcr tests)
added new function to calendars
Allow client_id to be overridden in __init__ (for replayable HTTP requests in pyvcr tests)
Fix 'ValueError: year is out of range' when year is set to 0000
This was referenced Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code from https://github.com/PeterHedley94/pyicloud to fix the auth issue (and other things apparently).
I can't claim to be an expert in how this works. But I cleaned out the old
pyicloud/base.pyfile and the merge seemed to apply cleanly topyicloud-ipd/base.pythen.Discussion in: icloud-photos-downloader/icloud_photos_downloader#139