Add command line arguments to filter by date. #779
Conversation
With the new argments --date-before and --date-after, user can choose to only download items that are created either before, after, or before and after the specified dates. Dates are assumed to be specified in the local timezone.
|
@AndreyNikiforov should be ready for re-review |
| files_in_result = glob.glob(os.path.join( | ||
| data_dir, "**/*.*"), recursive=True) | ||
|
|
||
| assert sum(1 for _ in files_in_result) == 0, "No files should have been downloaded." |
There was a problem hiding this comment.
pls adjust the test to have a set of files to download with different created dates and then "cut" that set with your new parameter. Confirm that only desired portion of the set is downloaded. That should confirm that criteria filtering is correct and test itself is not broken (as it downloads some files).
There should be tests that validate filters in this manner.
| @@ -418,6 +452,18 @@ def download_photo_(counter: Counter, photo: PhotoAsset) -> bool: | |||
| photo.created) | |||
| created_date = photo.created | |||
|
|
|||
| if created_before and created_date > created_before: | |||
There was a problem hiding this comment.
These are the conditions we need to validate with a test. Parameter absence is tested, but comparison is not completely validated IMO - need to check we indeed leave some assets and filter out others (assets created on the same date as parameter is the case that should be present in tests as well). In e2e tests that will be translated into checking that some files are downloaded and some are not.
|
@itwasabhi Is there any chance you can do the changes requested? It's a useful feature so thank you for developing it. |
|
@mrsilver76 Sure, please give me a week or so to sync to head and make the requested changes! |
|
@itwasabhi do you think you will get back to it somewhere in the future :) ? This would a game-changer for date based deletion. |
|
@itwasabhi Is there any chance you can make the changes requested by the code review? I ask because I'm trying to create an automated process to download photos from iCloud and then group and move them elsewhere. As I don't keep the files in their original download location, I need some way to tell icloudpd not to download photos any earlier than the date the process was last run. Thank you! |
With the new arguments --date-before and --date-after, user can choose to only download items that are created either before, after, or before and after the specified dates. Dates are assumed to be specified in the local timezone.
This should address issue #466, something I have also wanted for a while!
Comments / suggestions welcome.