Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump v1.17.3 #761

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## 1.17.3 (2024-01-03)

- improve compatibility for diffeent platforms [#748](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/748)

## 1.17.2 (2023-12-22)

- fix: module not found [#748](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/748)
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,21 +121,21 @@ scripts/build
Building platform executables:

``` sh
scripts/build_bin_linux 1.17.2 amd64
scripts/build_bin_linux 1.17.3 amd64
```
Note: that command is for Linux, including devcontainers. Windows & MacOS scripts must be executed on respective platforms.

Building Python wheels (with single executables; platform-specific):

``` sh
scripts/build_binary_dist_linux 1.17.2
scripts/build_binary_dist_linux 1.17.3
```
Note: that the step expects executables to be already prepared by previous step

Building NPM packages (with single executables; platform-specific):

``` sh
scripts/build_npm 1.17.2
scripts/build_npm 1.17.3
```
Note: that the step expects executables to be already prepared by previous steps

Expand Down
6 changes: 3 additions & 3 deletions EXPERIMENTAL.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,17 @@ Legacy command (compatible with prior versions):

`docker run -it --rm icloudpd:icloudpd icloud --help`

`icloudpd-1.17.2-windows-amd64 --help`
`icloudpd-1.17.3-windows-amd64 --help`

Help:

`docker run -it --rm icloudpd:icloudpd`

`icloudpd-ex-1.17.2-windows-amd64 --help`
`icloudpd-ex-1.17.3-windows-amd64 --help`

Example:

`docker run -it --rm icloudpd:icloudpd copy [email protected] /path/to/{album}/{date_created:%Y/%Y-%m}`

`icloudpd-ex-1.17.2-windows-amd64 copy [email protected] /path/to/{album}/{date_created:%Y/%Y-%m}`
`icloudpd-ex-1.17.3-windows-amd64 copy [email protected] /path/to/{album}/{date_created:%Y/%Y-%m}`

10 changes: 5 additions & 5 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@ Access to iCloud.com is blocked from mainland China. `icloudpd` can be used with

Here are the steps to make it working:
- download binary from Github [Releases](https://github.com/icloud-photos-downloader/icloud_photos_downloader/releases) into desired local folder
- add executable flag by running `chmod +x icloudpd-1.17.2-macos-amd64`
- start it from the terminal: `icloudpd-1.17.2-macos-amd64`
- add executable flag by running `chmod +x icloudpd-1.17.3-macos-amd64`
- start it from the terminal: `icloudpd-1.17.3-macos-amd64`
- Apple will tell you that it cannot check for malicous software and refuse to run the app; click "Ok"
- Open "System Settings"/"Privacy & Security" and find `icloudpd-1.17.2-macos-amd64` as blocked app; Click "Allow"
- Start `icloudpd-1.17.2-macos-amd64` from the terminal again
- Open "System Settings"/"Privacy & Security" and find `icloudpd-1.17.3-macos-amd64` as blocked app; Click "Allow"
- Start `icloudpd-1.17.3-macos-amd64` from the terminal again
- Apple will show another warning; click "Open"
- After that you can run `icloudpd-1.17.2-macos-amd64 --help` or any other supported command/option
- After that you can run `icloudpd-1.17.3-macos-amd64 --help` or any other supported command/option
2 changes: 1 addition & 1 deletion binary_dist/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ requires = [
build-backend = "setuptools.build_meta"

[project]
version="1.17.2"
version="1.17.3"
name = "icloudpd"
description = "icloudpd is a command-line tool to download photos and videos from iCloud."
readme = "README_PYPI.md"
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ requires = [
build-backend = "setuptools.build_meta"

[project]
version="1.17.2"
version="1.17.3"
name = "icloudpd"
description = "icloudpd is a command-line tool to download photos and videos from iCloud."
readme = "README_PYPI.md"
Expand Down
28 changes: 14 additions & 14 deletions scripts/publish_pypi
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#!/bin/bash
set -euo pipefail

# dev script
# expecting dist/binary_dist to be set
# required param registry_url
#
# prereq
# disable auth on pypi server
#
# cleint use: pip install --index http://192.168.1.20:4880 --trusted-host 192.168.1.20 icloudpd

# linux
twine upload --repository-url $1 --non-interactive -u bogus -p bogus dist/icloudpd-1.17.2-py2.py3-none-manylinux*.whl dist/icloudpd-1.17.2-py2.py3-none-macos*.whl dist/icloudpd-1.17.2-py2.py3-none-win*.whl dist/icloudpd-1.17.2-py3-none-any.whl
#!/bin/bash
set -euo pipefail
# dev script
# expecting dist/binary_dist to be set
# required param registry_url
#
# prereq
# disable auth on pypi server
#
# cleint use: pip install --index http://192.168.1.20:4880 --trusted-host 192.168.1.20 icloudpd
# linux
twine upload --repository-url $1 --non-interactive -u bogus -p bogus dist/icloudpd-1.17.3-py2.py3-none-manylinux*.whl dist/icloudpd-1.17.3-py2.py3-none-macos*.whl dist/icloudpd-1.17.3-py2.py3-none-win*.whl dist/icloudpd-1.17.3-py3-none-any.whl
2 changes: 1 addition & 1 deletion src/icloudpd/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
)
# a hacky way to get proper version because automatic detection does not
# work for some reason
@click.version_option(version="1.17.2")
@click.version_option(version="1.17.3")
# pylint: disable-msg=too-many-arguments,too-many-statements
# pylint: disable-msg=too-many-branches,too-many-locals
def main(
Expand Down
Loading