Auto delete date fix testing #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steffenmartin some tests are failing - pls fix. the PR should have all tests green. If anybody decides to validate fix for the test before the fix for the code, they will have to change some files locally IMO. |
…oud-photos-downloader#345 Due to the usage of local time conversions tests were sensitive to execution on machines in a different time zones. Now using timestamp to get beyond this issue.
Ok, ready for a re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyNikiforov, here's my first attempt of a comprehensive fix for this bug. I hope this is in adherence to all contributing guidelines.
Since test test_autodelete_photos inside of tests/test_autodelete_photos.py was already performed incorrectly it is somewhat difficult to perform a before-after comparison. If that's needed I suggest to first apply the follow patch to it.
This will make it fail in its current state. And once this PR has been merged it will pass again.