Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package icloudpd as one executable #529

Conversation

AndreyNikiforov
Copy link
Collaborator

@AndreyNikiforov AndreyNikiforov commented Jan 17, 2023

A lot of support questions come from people who struggle to configure pre-requisites (python) correctly. Packaging python and icloudpd into one binary with no pre-requisites will help a lot.

As a side effect, python 3.6 had to be deprecated as it is not supported by the tool used for packaging (pyinstaller)

Mentioned in #146

@AndreyNikiforov AndreyNikiforov changed the title package icloudpd as one executable package icloudpd as one executable #146 Jan 17, 2023
@AndreyNikiforov AndreyNikiforov changed the title package icloudpd as one executable #146 package icloudpd as one executable Jan 17, 2023
@menkej
Copy link
Collaborator

menkej commented Jan 18, 2023

Hi Andrey! You've been busy! I'll try to have a look at it soon, but I'm currently buried in some private and work related challenges, so I'll probably not be able to have a look at it within the next two weeks. I'll try.

@AndreyNikiforov AndreyNikiforov merged commit 5ee4613 into icloud-photos-downloader:master Jan 18, 2023
@AndreyNikiforov AndreyNikiforov deleted the feature/executable branch January 18, 2023 20:11
@AndreyNikiforov
Copy link
Collaborator Author

Hi Andrey! You've been busy! I'll try to have a look at it soon, but I'm currently buried in some private and work related challenges, so I'll probably not be able to have a look at it within the next two weeks. I'll try.

@menkej thanks for the prompt response. I wanted to get new build out of the door this week with whatever PRs are ready plus this new feature (as experimental). I hope I will be give more support for the project next number of weeks and fix bugs. I evaluated changes in this PR as low risk as they mostly touch workflows, so I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants