Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Automatically Delete Downloaded Photos #314

Closed
sabaatworld opened this issue Mar 15, 2021 · 10 comments
Closed

Option to Automatically Delete Downloaded Photos #314

sabaatworld opened this issue Mar 15, 2021 · 10 comments

Comments

@sabaatworld
Copy link

Summary

Please consider adding the ability to delete downloaded photos. When this option is used, the program would automatically delete the original assets from iCloud after downloading them.

Context

This would be very useful for people like me who would like to backup all their photos periodically to their computer. If my iCloud storage is full, all photos would not be backed up to iCloud and I would need to figure out the ones I've downloaded to my computer manually, and delete them to clear space.

With the delete option, I know that I would be deleting the ones which are already backed up, clearing space in my iCloud account without any manual intervention.

@ricmik
Copy link

ricmik commented Mar 15, 2021

Sounds dangerous. One thing is to re-download files from iCloud that has been deleted locally.

But restoring thousands of photos and videos that has been deleted on iCloud.. is that even possible?

@sabaatworld
Copy link
Author

Why would restoring be a concern? This option would be just for deleting the assets. They can be moved to the recycle bin where people can restore them if done by mistake.

@mooreandrew
Copy link

I've modified the app to do this. I added 2 flags:
--download-delete-age (defaults to 30 days)
--delete-if-downloaded (defaults to false)

If you want to see the code then it is here:
master...mooreandrew:master

I've never had an issue with it being dangerous, iCloud Photos is quite safe as all this does it move it to the deleted folder, of which it is really simple to restore (just select all and click recover).

This is how I got around the 5GB limit on iCloud.

@sabaatworld
Copy link
Author

That's awesome! Thanks a lot!

@jniggemann
Copy link

Will this be available in the next release?

@aztttt
Copy link

aztttt commented May 27, 2021

I want to recover the deleted videos from recycled bin

@sabaatworld
Copy link
Author

I pulled the code today to check out this option but I think its not merged into master yet. Is there something blocking the merge?

@christian1211
Copy link

I've modified the app to do this. I added 2 flags: --download-delete-age (defaults to 30 days) --delete-if-downloaded (defaults to false)

If you want to see the code then it is here: master...mooreandrew:master

I've never had an issue with it being dangerous, iCloud Photos is quite safe as all this does it move it to the deleted folder, of which it is really simple to restore (just select all and click recover).

This is how I got around the 5GB limit on iCloud.

I just tried to implement your changes but I keep getting the error Error: no such option: --delete-if-downloaded.
Could you tell me if there is more to do besides modifying the files?

@boredazfcuk
Copy link
Contributor

I've attempted to integrate this patch into my container, but it doesn't work correctly.

It doesn't see any of the photos in my (already downloaded) library and starts downloading them with -original appended to the file names. This would have duplicated my entire library had I not spotted it in time.

@AndreyNikiforov
Copy link
Collaborator

@sabaatworld v1.8.0 has this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants