Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download once #153

Closed
rocksolidsr opened this issue Apr 12, 2022 · 5 comments
Closed

Only download once #153

rocksolidsr opened this issue Apr 12, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@rocksolidsr
Copy link

Is it possible to only download files once? So I would like to grab the files from iCloud then import them into Photoprism but when the import happens it moves the files and then when the re-sync happens it redownloads all the same files again.

@rocksolidsr
Copy link
Author

Looks like someone has implemented it:
icloud-photos-downloader/icloud_photos_downloader#314

icloud-photos-downloader/icloud_photos_downloader@master...mooreandrew:master

Is it possible to get this implemented in this docker?

@boredazfcuk boredazfcuk self-assigned this Apr 12, 2022
@boredazfcuk boredazfcuk added the enhancement New feature or request label Apr 12, 2022
@boredazfcuk
Copy link
Owner

Hi,

I'll look into it over the next few days. I'd have to re-base my image to the repo, but then I don't know how that will turn out. The original repo does seem to have died somewhat, so maybe the new branch is the future. I'd like to avoid it if possible though.

So I'll see if I can diff the modifications in the new repo and apply them to the original repo after I clone it.

Probably take a few days though. I've been super busy the past couple of months, so I've been ignoring issues logged here. All that has finished now though, so I should have extra spare time in the evenings to look at it.

Thanks.

@rocksolidsr
Copy link
Author

That would be awesome! I would greatly appreciate it!
Thanks!

@boredazfcuk
Copy link
Owner

Hi,

I've applied this patch to my container, but unfortunately it doesn't work correctly. It does something which affects how files are named and unfortunately that meant it attempted to duplicate my entre photo collection.

I'll not be able to implement such a breaking change to my container as it will affect a lot of people.. so unless a different patch is created which respects the original file names, I'll not be able to integrate it.

Sorry about that.

@rocksolidsr
Copy link
Author

I understand that makes sense, thanks for trying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants