Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip problematic tests on mac #215

Merged
merged 1 commit into from
Nov 8, 2020
Merged

skip problematic tests on mac #215

merged 1 commit into from
Nov 8, 2020

Conversation

AndreyNikiforov
Copy link
Collaborator

date handling tests do not work on win and mac. skipping them until we have time to dig deeper.

all tests are passing (or skipping) on all platforms now

@AndreyNikiforov AndreyNikiforov mentioned this pull request Nov 8, 2020
Closed
menkej
menkej approved these changes Nov 8, 2020
View reviewed changes
Copy link
Collaborator

@menkej menkej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do this but should file an issue to fix the skipped tests right away, so that this is not forgotten forever. The tests should be portable as well or have platform specific pendants...

@AndreyNikiforov AndreyNikiforov merged commit eff6955 into icloud-photos-downloader:master Nov 8, 2020
@AndreyNikiforov AndreyNikiforov deleted the bug/macos-tests branch November 8, 2020 08:26
@AndreyNikiforov AndreyNikiforov mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@menkej menkej menkej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreyNikiforov @menkej