Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #200, --only-print-filenames (again) #201

Merged
merged 3 commits into from
Nov 5, 2020
Merged

fixes #200, --only-print-filenames (again) #201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c1117
fixes #200, --only-print-filenames (again)
menkej Nov 2, 2020
d8b25e1
tests for live-photo download
menkej Nov 4, 2020
9c58a4e
Merge branch 'master' into fix-200
menkej Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- fix: --only-print-filenames option displays filenames (live photos) of files that have already been downloaded #200

## 1.7.0 (2020-11-1)

- fix: --log-level option [#194](https://github.com/icloud-photos-downloader/icloud_photos_downloader/pull/194)
Expand Down
2 changes: 1 addition & 1 deletion icloudpd/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def download_photo(counter, photo):

lp_file_exists = os.path.isfile(lp_download_path)

if only_print_filenames:
if only_print_filenames and not lp_file_exists:
menkej marked this conversation as resolved.
Show resolved Hide resolved
print(lp_download_path)
else:
if lp_file_exists:
Expand Down