Merge pull request #277 from menkej/fix-227

Fix 227
icloud-photos-downloader · Jan 4, 2021 · 7b8fe2e · 7b8fe2e
2 parents 5b58aa4 + 6b0215b
commit 7b8fe2e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- fix: smtp server_hostname cannot be an empty [#227](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/227)
+
 ## 1.7.1 (2020-11-15)
 
 - fix: dev docker build on windows correctly manages crlf for scripts

diff --git a/icloudpd/email_notifications.py b/icloudpd/email_notifications.py
@@ -15,8 +15,10 @@ def send_2sa_notification(
     from_addr = smtp_email if smtp_email else to_addr
     logger = setup_logger()
     logger.info("Sending 'two-step expired' notification via email...")
-    smtp = smtplib.SMTP()
+    smtp = smtplib.SMTP(smtp_host, smtp_port)
     smtp.set_debuglevel(0)
+    # leaving explicit call of connect to not break unit tests, even though it is
+    # called implicitly via cunstructor parameters
     smtp.connect(smtp_host, smtp_port)
     if not smtp_no_tls:
         smtp.starttls()