Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length #217

Merged
merged 7 commits into from
Jun 18, 2022
Merged

Fix length #217

merged 7 commits into from
Jun 18, 2022

Conversation

ichiban
Copy link
Owner

@ichiban ichiban commented May 6, 2022

#191

This PR re-implements length/2 as described in http://www.complang.tuwien.ac.at/ulrich/iso-prolog/prologue#length

Also, improved cycle detection with Brent's cycle detection algorithm.

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #217 (09049e9) into main (c84f442) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   97.13%   97.18%   +0.04%     
==========================================
  Files          21       21              
  Lines        6394     6505     +111     
==========================================
+ Hits         6211     6322     +111     
  Misses        151      151              
  Partials       32       32              
Impacted Files Coverage Δ
cmd/1pl/interpreter.go 100.00% <100.00%> (ø)
engine/builtin.go 96.58% <100.00%> (+0.13%) ⬆️
engine/compound.go 100.00% <100.00%> (ø)
engine/env.go 98.26% <100.00%> (+0.09%) ⬆️
engine/iterator.go 100.00% <100.00%> (ø)
engine/number.go 100.00% <100.00%> (ø)
engine/promise.go 100.00% <100.00%> (ø)
interpreter.go 94.90% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84f442...09049e9. Read the comment docs.

@ichiban ichiban merged commit dda2b60 into main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants