-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are too many mandatory fields #26
Comments
Hi, for the example above people should use NaN (Not A Number) for float or double to indicate invalid values. |
Hi, thanks for the response. |
Hi, Do you have any concrete example were lat/lon data would be missing ? Data are supposed to be acquired by some physical device, and thus can be georeferenced, even if the sounder in in a fixed position. This allow to develop algorithm that works for every files allowing geolocalisation of data in space (like echo integration, display of data in SIG 2D/3D, ...) . |
The key point is "data can be georeferenced", but it doesn't have to be. The echosounder itself does not require georeferencing to function. The important point is that this is trying to force the user's work paradigm. This is unlikely to work, because there is no "correct paradigm" for working with acoustics. It is too varied a field for there to be a single method which can be applied to all cases. |
Version 1 of the convention has the geographic position as MA (mandatory if available/applicable), for this reason - not all uses of sonars (or echosounders) need, or will have, position. And in some cases the position is unavailable - e.g., equipment failures, or the Simrad WBAT (which can't currently receive a GPS feed) - in these cases it can be added afterwards, but this shouldn't prevent data directfrom the instrument from meeting the convention. The convention hasn't really resolved whether to prefer variables containing a 'no data' value or whether the variable should be absent. Currently, both are used in different places. Comments on this? |
I'd prefer the data to be absent if it's not appliccable because it allows us to differentiate the cases where: It's useful for the software to be able to post warning messages in the case of b) to tell the user that something is wrong. Whereas in case a) there is no error so we don't want to warn |
Further to the above, Furuno have raised some queries regarding mandatory variables that lead to these questions:
Comments on the above welcome... |
1 : It seems to me that substitute_value_used is used both for MA and M variables for example receive_duration_effective, 2 : I think heading both in attitude_sub_group and position_sub_group should be set as Mandatory. As far as I know every sensor provides these data. 3 : I'm in favor of M allows NaN. My feeling is that having variable defined whenever it is possible will make the format more consistent and more simple than have to code a set of test or check ancillary variables explaining why something is declared or not. This makes the share of method or tools more easy and helps the use of the format. |
Bonjour to all: @gavinmacaulay, @cyrilleponcelet, @geoffmatt, I would like to make comments on the items 2 and 3, based on our common understandings of the “M” and “MA” obligations. The convention, since Version 1.0 (CRR No. 341), states that: My understandings are: For further discussions, Any other comments would be appreciated too. |
My opinions:
I will think some more about the M/MA and NaN options and combinations - there are benefits and disadvantages to both of the main options... |
I am in agreement with Okunishi-san (@akiraokunishi) on this one.
|
Gavin-san (@gavinmacaulay), Geoff-san (@geoffmatt), (C4) “Mandatory” obligation Your opinions led me to look at a phrase in the existing convention (in (S1) above): It seems that adding a statement below, after this sentence, can clearly and uniquely define the “minimal set” and then “mandatory” in this convention for sonar data: (Sa) “Specifically, this is the set of data required to evaluate target strengths and volume backscatter strengths using proper types of conversion equations.” The existing statement below also should be maintained. (C5) “Mandatory if applicable” obligation Geoff-san gave a specific example for “mandatory if applicable”. (Sb) “Variables that are required for only particular (i.e., not all) types of the equations have been given ‘mandatory if applicable’ obligations”. (C6) “Mandatory if available” obligation I think I understand the flaw that Geoff-san points out. However, I also understand that “mandatory” in this convention simply means “must be recorded” for sonars. For further discussions, Any other comments would be appreciated too. |
I've read through this issue to figure out how to interpret the convention regarding whether MA variables for which no data is available must be present but filled with NaN, or can be omitted. The dicussion here has been very helpful. As far as I can see, though, there's no definitive position in the convention or here. As @gavinmacaulay stated earlier in the issue:
The statement in the convention documents (both vers. 1 & 2), "Any non-mandatory variables can be absent from a SONAR-netCDF4 file", has its own ambiguity: Does this mean that MA variables can be absent, or is it referring only to R and O variables? I see that there are programmatic pros and cons for either approach. On the cons, an extreme example would be Further discussions about whether some variables should be redesignated from Mandatory (M) to MA also seem unresolved. @akiraokunishi's most recent comments were a helpful refinement. At a minimum, I think there's tacit agreement that omitting MA variables falls within current practice. Is that a reasonable conclusion? Thank you. |
Hi @emiliom I agree with you that there is an tacit agreement that omitting MA variable if they have no meaning here. |
Thanks so much for your input, @cyrilleponcelet. That's very helpful. |
This is a general problem with implementing this format.
There are a very large number of mandatory fields, the majority of which are not actually required for all applications of acoustic data.
For example platform latitude, longitude and heading in the beam group table. These would typically be useful parameters, but it is an assumption that they are mandatory. Many acoustic data sets are recorded (for better or worse) without accompanying GPS. By making these fields mandatory we are forcing people to write nonsense values into them. This is especially problematic for fields such as longitude and latitude because it is likely that the nonsense value will be 0.0, however this is a valid Long or Lat value. Therefore if becomes impossible for the reader to determine if these values should be used or not, introducing bugs.
The text was updated successfully, but these errors were encountered: