Add new KeepAliveInterval option in QuicClientTransportOptions #3991
Conversation
| /// provided by the underlying implementation".</value> | ||
| /// <remarks>The idle timeout is negotiated by QUIC during connection establishment. The actual idle timeout value | ||
| /// for a connection can be lower than the value you've set here.</remarks> | ||
| public TimeSpan IdleTimeout { get; set; } = TimeSpan.FromSeconds(30); |
There was a problem hiding this comment.
Changed the default from Zero to 30 seconds - which is the msquic default (= what Zero meant). It's clearer to spell out the actual default, and it's highly desirable to use the same default in all IceRPC implementation.
| @@ -43,7 +43,7 @@ public class CompressorInterceptorTests | |||
| new BrotliStream(outStream, CompressionMode.Decompress) : | |||
| new DeflateStream(outStream, CompressionMode.Decompress); | |||
| var decompressedPayload = new byte[4096]; | |||
| await decompressedStream.ReadAsync(decompressedPayload); | |||
| await decompressedStream.ReadAtLeastAsync(decompressedPayload, _payload.Length); | |||
There was a problem hiding this comment.
These are tiny unrelated fixes for analyzer warnings introduced in .NET 9.0.
| // Without the keep-alive interval, the idle timer aborts the connection after 500ms. | ||
| using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(2)); | ||
|
|
||
| #if NET9_0_OR_GREATER |
There was a problem hiding this comment.
This assumes the unit tests are built with the same version of .NET as the IceRpc.Transport.Quic assembly (a safe assumption).
| // Act/Assert | ||
|
|
||
| // Without the keep-alive interval, the idle timer aborts the connection after 500ms. | ||
| using var cts = new CancellationTokenSource(TimeSpan.FromSeconds(2)); |
There was a problem hiding this comment.
I think would be clear to write the response and close the stream after the delay.
There was a problem hiding this comment.
You're right, I reworked the test and removed the cancellation token source.
Note that with QUIC, canceling a read is fatal to the stream. You can't cancel reading and then start reading again. We may be doing the same in Slic.
This PR adds the new KeepAliveInterval option to QuicClientTransportOptions. It's implemented only with .NET 9.0.
Fixes #3353.