Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message at attempt to get fragmentManager #113

Conversation

ZiXOps
Copy link

@ZiXOps ZiXOps commented Apr 15, 2024

closes #106

@@ -21,7 +21,9 @@ actual fun BindEffect(permissionsController: PermissionsController) {
val context: Context = LocalContext.current

LaunchedEffect(permissionsController, lifecycleOwner, context) {
val fragmentManager: FragmentManager = (context as FragmentActivity).supportFragmentManager
val fragmentManager: FragmentManager = checkNotNull(context as? FragmentActivity) {
"$context context is not instance of FragmentActivity"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should describe here how to fix it, not just show error just like current

@Alex009
Copy link
Member

Alex009 commented Apr 17, 2024

we will complete #114 instead of this change

@Alex009 Alex009 closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants