Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Select All" functionality on Ctrl+A to TextEditor #2321

Merged
merged 1 commit into from
Jul 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/text/editor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ pub enum Action {
SelectWord,
/// Select the line at the current cursor.
SelectLine,
/// Select the entire buffer.
SelectAll,
/// Perform an [`Edit`].
Edit(Edit),
/// Click the [`Editor`] at the given [`Point`].
Expand Down
21 changes: 21 additions & 0 deletions graphics/src/text/editor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,27 @@ impl editor::Editor for Editor {
}));
}
}
Action::SelectAll => {
let buffer = editor.buffer();
if buffer.lines.len() > 1
|| buffer
.lines
.first()
.is_some_and(|line| !line.text().is_empty())
{
let cursor = editor.cursor();
editor.set_select_opt(Some(cosmic_text::Cursor {
line: 0,
index: 0,
..cursor
}));

editor.action(
font_system.raw(),
motion_to_action(Motion::DocumentEnd),
);
}
}

// Editing events
Action::Edit(edit) => {
Expand Down
5 changes: 5 additions & 0 deletions widget/src/text_editor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,11 @@ impl Update {
{
return Some(Self::Paste);
}
keyboard::Key::Character("a")
if modifiers.command() =>
{
return Some(Self::Action(Action::SelectAll));
}
_ => {}
}

Expand Down
Loading