Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fill variant for Alignment #1735

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Remove Fill variant for Alignment #1735

merged 1 commit into from
Feb 28, 2023

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Feb 27, 2023

Implementing this generically in our flex logic has an exponential cost. Let's explore other options!

@hecrj hecrj added feature New feature or request layout labels Feb 27, 2023
@hecrj hecrj added this to the 0.9.0 milestone Feb 27, 2023
Implementing this generically in our `flex` logic has an exponential
cost. Let's explore other options!
@hecrj hecrj force-pushed the remove-alignment-fill branch from 9c4d441 to 9e815cb Compare February 27, 2023 15:54
@hecrj hecrj merged commit 86b85d1 into master Feb 28, 2023
@hecrj hecrj deleted the remove-alignment-fill branch February 28, 2023 15:03
@nicoburns
Copy link
Contributor

This leads me to a good example of a layout that isn't achievable in a single pass: Even height columns where the height of all the columns should be determined by the content of the tallest column:

Screenshot 2023-02-28 at 20 31 08

@hecrj
Copy link
Member Author

hecrj commented Feb 28, 2023

It's certainly possible if we tackle this example directly:

  1. Measure all the text.
  2. Find maximum height.
  3. Set each outer container to the maximum height.

Text doesn't need to be relaid out; we can reuse the measurements. We only need multi-pass if we want to solve a generic problem (i.e. support any kind of content, not just text).

My point is... We need real use cases! There are probably very efficient ways to solve them directly.

@fhilgers
Copy link

fhilgers commented Jun 6, 2023

Sorry if this is a naive question, but how would I achieve the layout in the picture above with the current features?

@derezzedex
Copy link
Member

Can we reopen #746?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants