Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same name & order for checkbox::new and helper #1633

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

13r0ck
Copy link
Member

@13r0ck 13r0ck commented Jan 3, 2023

The helper function for the checkbox widget switched the order and name of the arguments passed when creating the checkbox widget. This just standardizes the order whether the dev is using the helper or the associated function.

Continuation of #1616

The helper function for the checkbox widget switched the order
and name of the arguments passed when creating the checkbox
widget. This just standardizes the order whether the dev is using
the helper or the associated function.

Continuation of iced-rs#1616
@13r0ck 13r0ck force-pushed the standardize-checkbox-functions branch from 1d6c8b2 to d8536e6 Compare January 4, 2023 19:41
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@hecrj hecrj merged commit d29849d into iced-rs:master Jan 5, 2023
@hecrj hecrj added the improvement An internal improvement label Jan 5, 2023
@hecrj hecrj added this to the 0.7.0 milestone Jan 5, 2023
@13r0ck 13r0ck deleted the standardize-checkbox-functions branch January 5, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants