-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more window actions #1525
add more window actions #1525
Conversation
@tarkah I'm trying to add Lines 28 to 33 in b4aedce
Lines 40 to 56 in b4aedce
to the my iced native icon https://github.com/Night-Hunter-NF/iced/blob/master/native/src/window/icon.rs but iced_native doesn't have image as a dep. just wondering what you thoughts are on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we are tackling multiple use cases here and some of the actions seem quite straightforward while some others may need further discussion.
Since there is not an RFC for these changes, I feel we should at least split this PR into smaller ones; one for each new action.
ok yup will work on splitting them up into different PRs |
split into prs above |
users should be able to with window::Actions:
There may be a better way to handle the type for the Icon enum but you cant import winit into iced_native due to cyclic package dependency's. feel free to say a better way then i have done.
Also what do people think the Action::Fullscreen should do? currently it full screens on primary monitor but IMO i think it should full screen on current monitor.
And should it be an option to full screen exclusive. currently you can only full screen windowed borderless