Make overlay::menu accessible
#1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note sure about the #1362 introduced the theme support allowing to implement a custom style for all widgets except the |
0x192
added a commit
to 0x192/universal-android-debloater
that referenced
this pull request
Sep 1, 2022
) Note: UAD is now temporarily based on my fork of Iced until iced-rs/iced#1425 is merged upstream. - Remove custom code for theming: UAD now uses the new Iced styling API - All the code for initializing UAD (download debloat lists, fetch connected devices etc...) is now a lot more streamlined - Other miscellaneous code improvement - Replace row() and column() functions by the new Iced vector-like helper functions (row![], column![]) - Move navigation menu GUI code in a dedicated file - Rework the way UAD uses events for async code
0x192
added a commit
to 0x192/universal-android-debloater
that referenced
this pull request
Sep 21, 2022
My pull request has been merged : iced-rs/iced#1425
|
Thanks to you! Why did you need to add this? I'm not sure to understand pub type Element<'a, Message, Renderer = crate::Renderer> =
iced_native::overlay::Element<'a, Message, Renderer>;(no problem if you don't have time to answer) |
|
Just figured we should expose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
pick_list::StyleSheetfor a customThemerequires to also implementmenu::StyleSheetwhich is currently not accessible.This pull request creates an alias of
overlay::menuin the root so you can import it withuse iced::overlay::menu.Fixes #1406