Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding pure text_input value during draw #1371

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Jun 23, 2022

iced_native::widget::TextInput defines a draw method to override it's Value when drawn. This adds the same functionality to the pure version.

Difference here is caller must provide the Tree with associated state in it for the text input and it's up to them to make sure this is safe.

@hecrj hecrj added improvement An internal improvement widget labels Jun 27, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

Certainly necessary to implement some custom widgets with composition.

@hecrj hecrj merged commit 799a7e5 into iced-rs:master Jun 27, 2022
@hecrj hecrj added this to the 0.4.3 milestone Jun 27, 2022
@tarkah tarkah deleted the feat/pure-text-input-value-override branch June 27, 2022 19:16
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants