Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power and Limits Auto configure and setting. #1280

Closed
wants to merge 2 commits into from
Closed

Power and Limits Auto configure and setting. #1280

wants to merge 2 commits into from

Conversation

genusistimelord
Copy link

Adjusted Limits so it uses what the adapter allows also changed the Power settings so it checks for High powered adapters first and then low powered.

This will attempt to use high powered GPU first if it fails to find any it will then use Low Powered GPU's 2nd Processor embedded and software based.

It will pull the required limits for None WASM to what the default adapter supports rather than setting it all to the lowest of low.
Should fix some issues with #1232 . We might also be able to add a 3rd check for fallback software devices which might allow WSL to work better when neither GPU are pass-thru acceptable. But will need to test that too.

…ower settings so it checks for High powered adapters first and then low powered
@genusistimelord
Copy link
Author

honestly the power part should not matter but I am wondering if something is broken on the wgpu side as to why changing it to low power mode for someone worked in a VM while it should have worked regardless.

Generally based on https://github.com/gfx-rs/wgpu/blob/df50028e49e1448b56ce71f7904921a95c15594c/wgpu-core/src/instance.rs#L735

which is suppose to parse thru each one till it finds an acceptable adapter the only difference is low and high just puts discrete or integrated first in the list. So I am wondering if it doesn't fail at

let adapter = match instance

But fails at

let (device, queue) = adapter
due to it not having access to the GPU directly. this needs to be tested so hoping @skydig and @Ploppz can test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant