Platform-specific Command implementations
#1019
Merged
+556
−323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to introduce a platform-specific `Action` to both `iced_native` and `iced_web` and remove the `Clipboard` from `Application::update` to maintain purity. Additionally, this should let us implement further actions to let users query and modify the shell environment (e.g. window, clipboard, and more!)
alex13sh
reviewed
Sep 2, 2021
hecrj
force-pushed
the
command-actions
branch
from
0910fdf to
01b945b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a platform-specific
Actionas an underlying implementation ofCommandto bothiced_nativeandiced_web.This allows us to remove the
ClipboardfromApplication::updateand keep it side-effect free (i.e. pure). Additionally, this should let us implement further actions to let users query and modify the shell environment (e.g. window, clipboard, and more!) without introducing more arguments toApplication::update, but instead leveraging theCommandAPI.As a consequence, the clipboard should be accessed by using the new
readandwritefunctions in the newclipboardmodule.Furthermore, I have added actions for interacting with the application window at runtime. The new
move_toandresizefunctions in thewindowmodule can be leveraged for this purpose.More actions coming soon!
Fixes #493.
Fixes #644.
Fixes #767.
Closes #930.