Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Mac OS X the wrong cursor type is displayed when hovering over a slider #9

Closed
mlindner opened this issue Sep 6, 2019 · 2 comments
Closed

On Mac OS X the wrong cursor type is displayed when hovering over a slider #9

mlindner opened this issue Sep 6, 2019 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
0.1.0

Comments

@mlindner
Copy link

mlindner commented Sep 6, 2019

When hovering over the slider the "hand with closed fingers" is displayed even before clicking. Normally that would transform to the "hand with closed fingers" when clicking and the "hand with open fingers" before clicking. I can't seem to take a screenshot of this however.
@hecrj
Copy link
Member

hecrj commented Sep 6, 2019 •
edited
Loading

Thanks for the report!

This is a winit issue, the windowing library that ggez uses. It looks like both grabbing and grab cursors are being mapped to the same "closed hand cursor".

Windows has a similar issue that I have already reported: rust-windowing/winit#1043

This issue is related to the example, not Iced itself. In any case, we should try to contribute and fix these!

@hecrj hecrj added the improvement An internal improvement label Sep 6, 2019
@hecrj hecrj changed the title On Mac OS X the wrong cursor type is displayed when hovering over a a slider On Mac OS X the wrong cursor type is displayed when hovering over a slider Sep 6, 2019
@hecrj hecrj added the good first issue Good for newcomers label Sep 6, 2019
ayazhafiz added a commit to ayazhafiz/winit that referenced this issue Sep 9, 2019
@ayazhafiz
fix: distinguish grab and grabbing cursors
a9a117e 
On MacOS, there is a difference between a "grab" cursor and a "grabbing"
cursor, where "grab" is an open-hand cursor used during a hover, and
"grabbing" is a closed-hand cursor used on a click. These, and other
native MacOS cursors, can be seen at the [NSCursor documentation](https://developer.apple.com/documentation/appkit/nscursor?language=objc).

See iced-rs/iced#9 for the motivation for this
PR.
ayazhafiz added a commit to ayazhafiz/winit that referenced this issue Sep 9, 2019
@ayazhafiz
fix: distinguish grab and grabbing cursors
a25cda1 
On macOS, there is a difference between a "grab" cursor and a "grabbing"
cursor, where "grab" is an open-hand cursor used during a hover, and
"grabbing" is a closed-hand cursor used on a click. These, and other
native MacOS cursors, can be seen at the [NSCursor documentation](https://developer.apple.com/documentation/appkit/nscursor?language=objc).

See iced-rs/iced#9 for the motivation for this
PR.
@ayazhafiz ayazhafiz mentioned this issue Sep 9, 2019
Merged
7 tasks
goddessfreya pushed a commit to rust-windowing/winit that referenced this issue Sep 12, 2019
@ayazhafiz @goddessfreya
fix: distinguish grab and grabbing cursors (#1154)
36f4ecc 
On macOS, there is a difference between a "grab" cursor and a "grabbing"
cursor, where "grab" is an open-hand cursor used during a hover, and
"grabbing" is a closed-hand cursor used on a click. These, and other
native MacOS cursors, can be seen at the [NSCursor documentation](https://developer.apple.com/documentation/appkit/nscursor?language=objc).

See iced-rs/iced#9 for the motivation for this
PR.
@hecrj hecrj added this to the 0.1.0 milestone Sep 24, 2019
@hecrj hecrj added bug Something isn't working and removed improvement An internal improvement labels Sep 24, 2019
@hecrj
Copy link
Member

hecrj commented Oct 23, 2019

This should be fixed in master 🎉

@hecrj hecrj closed this as completed Oct 23, 2019
CurryPseudo pushed a commit to CurryPseudo/iced that referenced this issue Apr 25, 2023
@KentaTheBugMaker
Merge pull request iced-rs#9 from t18b219k/ime_support
eb9d7d1 
range management fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@hecrj @mlindner