This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Feat: define routes and ignore route files #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/imsobear/ice-next/522G1md9aHG1mYDePofTnppKQtL4 |
ClarkXia
reviewed
Apr 1, 2022
examples/basic-project/ice.config.ts
Outdated
| // }, | ||
| routes: { | ||
| ignoreFiles: ['about.tsx'], | ||
| defineRoutes: (route) => { |
There was a problem hiding this comment.
新建个 example 吧，不要把所有 feature 都放到一个 example 里面
| @@ -89,14 +75,31 @@ async function createService({ rootDir, command, commandArgs }: CreateServiceOpt | |||
| }, | |||
| }); | |||
| await ctx.resolveConfig(); | |||
| const { userConfig: { routes: routesConfig } } = ctx; | |||
packages/ice/src/createService.ts
Outdated
| ...renderData, | ||
| ...routesRenderData, | ||
| })); | ||
| dataCache.set('routes', JSON.stringify(routesRenderData)); |
packages/ice/src/getWatchEvents.ts
Outdated
| @@ -49,7 +52,7 @@ const getWatchEvents = (options: Options): WatchEvent[] => { | |||
| ]; | |||
|
|
|||
| const watchConfigFile: WatchEvent = [ | |||
| new RegExp(configFile), | |||
| new RegExp(configFile as string), | |||
packages/ice/src/routes.ts
Outdated
|
|
||
| export function generateRoutesInfo(rootDir: string) { | ||
| const routeManifest = generateRouteManifest(rootDir); | ||
| export function generateRoutesInfo(rootDir: string, routesConfig?: UserConfig['routes']) { |
There was a problem hiding this comment.
routesConfig 为 undefined 的情况
chenjun1011
reviewed
Apr 8, 2022
chenjun1011
reviewed
Apr 8, 2022
chenjun1011
reviewed
Apr 8, 2022
| } else { | ||
| pathList.push(route.path || '/'); | ||
| pathList.push(path.join('/', parentPath, route.path || '')); |
There was a problem hiding this comment.
需要的，生成的路由 manifest 中路由第一个字符不是 /，这里需要加上 / 否则不能 match 上
ClarkXia
approved these changes
Apr 13, 2022
chenjun1011
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60