Issues/50 from ical #226
Issues/50 from ical #226
Conversation
Conflicts: spec/examples/monthly_rule_spec.rb
Adds both Schedule.from_ical & Rule.from_ical
|
Referencing old issue (#86) |
|
👍 nice work |
…g start_time instead
|
Ooh, can't wait 👍 |
| @@ -142,12 +147,25 @@ def self.wday_to_sym(wday) | |||
| end | |||
| end | |||
|
|
|||
| # Convert a symbol to an ical day (SU, MO) | |||
| def self.week_start(sym) | |||
| raise "No such day: #{sym}" unless DAYS.keys.include?(sym) | |||
There was a problem hiding this comment.
It might be nice to class these exceptions to they're easier to rescue.
There was a problem hiding this comment.
Just pushed up a change, thanks for the feedback @btucker
… the Exception could be rescued
|
@avit & @seejohnrun ... anything else we need to do to get this merged in? |
|
👍 |
|
i'm down - what do you think @avit? |
|
Reviewing today, I'll let you know if there's anything obvious otherwise it's going in. It's taken so long because we don't use this functionality, but I think it's a disservice to the project to leave it out any longer. Let's get it in there and if any issues come up, we'll try and support it with everyone's help and contributions. |
|
Thank you guys! |
|
@spra85, good work 👍. Excited to see this merged |
|
Thanks @mooremo ... but have to deflect any thanks to everybody else in the commit log for this PR. All I did is deal with the rebase and move some logic around. Others did the meat of the work. |
|
I looked at this on the weekend. There's a lot of stuff happening in the commit log that should not be a part of this change:
I'm going to flatten it all down to a single commit to clean it out. It'll break the history in the commit log for this branch, but there's like 4 years of back-and-forth integration between various people's forks in there and it's a mess to follow the actual relevant changes. I also looked into using the icalendar gem to deal with the parsing & output to ical. It might be a better approach in the long run, but for now we can merge the current implementation, pending cleanup. |
|
Well then 👍 to everyone else too 😄 |
Instead of raising an exception, we have decided to ignore BYSETPOS for now.
Issues/bysetpos in ical
|
--> #258 |
|
I think there is an issue/bug where dates are parsed in a recurrence rule. Sometimes dates are expressed sans the time component, e.g. “UNTIL=20150920”, and in this case we should use the time zone of the calendar rather than UTC. |
|
Thanks - I can see this might be an issue. Reading RFC2445 indeed Looking into this in more detail, I'm getting the idea that this pull request doesn't actually supports timezones (e.g. Moving to icalendar can be useful, but that's probably a long stretch. |
|
merged roll-up commit by @wvengen now - so closing this down (please re-open if we're missing something) huge thanks to everyone and sorry for the massive delay - I'm going to be more active on this project moving forward |
This is new, freshly rebased PR for continuing from_ical issue implementation -