Use Enumerator to model occurrences in Schedule #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ❤️ this! I've been thinking about doing this for a long time. Let me review, I'll add some inline comments. |
|
+1 |
|
Thanks for the feedback! Let me know if/what you need from me moving forward on this, if anything. |
| block_given? ? block.call(res) : (answers << res) | ||
| answers.shift if tail_limit && answers.length > tail_limit | ||
| break if limit && answers.length == limit | ||
| e = Enumerator.new do |yielder| |
There was a problem hiding this comment.
Tiny nit: the Enumerator is implicitly returned, the e is an unused variable.
|
Thanks for the catch, ches. Sorry to wake this thread back up. I wasn't sure if there was anything else I needed to do with this. I don't make pull requests often (this might be my first one) so I'm a bit flimsy on the process. |
|
@igraves thanks for the pull request and sorry for the delay. great PR |
seejohnrun
added a commit
that referenced
this pull request
Jan 23, 2014
Use Enumerator to model occurrences in Schedule
seejohnrun
added a commit
that referenced
this pull request
Feb 6, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been encountering some use-cases where I need to deal with infinite lists of recurring events in a manageable way. Using an Enumerator to do this in a less-eager fashion seems like a good way to approach the problem. I replaced find_occurrences() in Schedule with enumerate_occurrences() and rewrote all the calls to find_occurrences() accordingly. Additionally, I added two methods that emit the underlying enumerator so one can use an enumerator to manage a (potentially infinite) list of occurrences.