Don't swallow exceptions -- throw them up instead #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions, and in particular
IOException
in networking code, should not be swallowed but thrown up to the caller, such that an appropriate error message can be generated for the end user. The client is still free to wrap allical4j
-Methods in a catch-alltry-catch
.I made a fairly mechanic change to all the catch clauses:
e.printStackTrace()
withthrow new RuntimeException(..., e)
for all checked exception'scatch
clauses.catch
clauses forNullPointerException
inAbstractDavObjectCollection::getProperty(DavPropertyName propertyName, Class<P> type)
throw UnsupportedOperationException(...)
in obviously unimplemented methods