Skip to content

Commit

Permalink
Minor: Make serializableCoder warning gramatically correct english (a…
Browse files Browse the repository at this point in the history
…pache#17020)

* Make serializableCoder warning gramatically correct english

Currently it is `This may produce incorrect results on some PipelineRunner` which is a bit awkward

* Noop
  • Loading branch information
dpcollins-google authored Mar 16, 2022
1 parent ad21d83 commit f7d9e6a
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ private static <T extends Serializable> void checkEqualsMethodDefined(Class<T> c
if (warn && MISSING_EQUALS_METHOD.add(clazz)) {
LOG.warn(
"Can't verify serialized elements of type {} have well defined equals method. "
+ "This may produce incorrect results on some {}",
+ "This may produce incorrect results on some {} implementations",
clazz.getSimpleName(),
PipelineRunner.class.getSimpleName());
}
Expand Down Expand Up @@ -169,8 +169,11 @@ public <T> Coder<T> coderFor(

private final Class<T> type;

/** Access via {@link #getEncodedTypeDescriptor()}. */
// the field is restored lazily if it is not present due to serialization
/**
* Access via {@link #getEncodedTypeDescriptor()}.
*
* <p>The field is restored lazily if it is not present due to serialization.
*/
@SuppressFBWarnings("SE_TRANSIENT_FIELD_NOT_RESTORED")
private transient @Nullable TypeDescriptor<T> typeDescriptor;

Expand Down

0 comments on commit f7d9e6a

Please sign in to comment.